[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Request for Review: sword



On Fri, 2005-06-03 at 07:47 -0500, Tom 'spot' Callaway wrote:
> On Fri, 2005-06-03 at 13:55 +0200, Nils Philippsen wrote:
> > On Wed, 2005-06-01 at 18:27 -0500, Tom 'spot' Callaway wrote:
> > > On Wed, 2005-06-01 at 15:50 +0200, Nils Philippsen wrote:
> > > 
> > > >  %install
> > > > -rm -rf $RPM_BUILD_ROOT
> > > > -make install DESTDIR=$RPM_BUILD_ROOT
> > > > +rm -rf %buildroot
> > > > +make install DESTDIR=%buildroot
> > > >  %__mkdir_p %buildroot%_datadir/sword/modules
> > > > 
> > > >  find %buildroot%_libdir -type f -name "*.la" -exec rm -f {} ';'
> > > > 
> > > >  %clean
> > > > -rm -rf $RPM_BUILD_ROOT
> > > > +rm -rf %buildroot
> > > 
> > > FWIW, these changes are NOT necessary. $RPM_BUILD_ROOT is perfectly
> > > valid and acceptable, as long as its consistent.
> > 
> > It wasn't consistent ;-) -- I could either replace %buildroot with
> > $RPM_BUILD_ROOT or vice versa (which I did).
> 
> Whoops. Sorry. :)

Well, I _could_ have used the word "inconsistent" somewhere instead of
the raw diff, but that would have been like providing source code
instead of only strace output ;-P.

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp redhat com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]