Nils Philippsen nphilipp at redhat.com
Fri Mar 4 19:19:44 UTC 2005

On Fri, 2005-03-04 at 18:55 +0100, Matthias Saou wrote:
> Nils Philippsen wrote :
> > Thanks. I've just imported the package and did some changes in order to
> > get it more FE compliant ;-), but the release is not bumped yet (and not
> > tagged, see my other mail on that issue).
> OK, here I go :-)
> - I've remove "A " from the summary, and the trailing dot too. (1)


> - Dump SOURCE2 (the icon) as you don't use it
>   - or -
> - Install SOURCE2 in /usr/share/pixmaps/ and remove the full path from
>   the desktop entry to make it themeable.

done (the latter)

> - Remove the "grep" BuildRequires, I don't think it's useful

yes and done

> - Eventually put the %doc right after the %defattr, as this is more common


> Now... I don't have 3D acceleration on my laptop (Mobility 9600...), so
> I've only gone though the spec... I'll leave others "review" the part where
> you actually run the program :-/

well I tried it, but I don't count, now do I ;-)?

     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"They that can give up essential liberty to obtain a little temporary
 safety deserve neither liberty nor safety."     -- B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011

More information about the fedora-extras-list mailing list