no xfce for FC4?

[Tom 'spot' Callaway]

On Mon, 2005-03-07 at 12:35 -0700, Kevin Fenzi wrote:

>I'm hoping to get some good feedback from the specs/packages and find
>someone interested in sponsoring me to maintain the xfce packages in
>fedora extras. 

I'm not an xfce user, but I took the time tonight to download your SRPMs
to review them. A few items of note:

All packages:

-Source0:
http://www.xfce.org/archive/xfce-4.0.3/src/%{name}-%{version}.tar.gz
+Source:
http://www.us.xfce.org/archive/xfce-4.2.0/src-bz2/libxfce4mcs-4.2.0.tar.bz2

Fixing the link is good, but I'd prefer you kept the Source0. Yes, its
purely stylistic, but it sets a good example for other packagers who
have multiple sources, and helps avoid things like:

Source: foo.tar.gz
Source43: foobar.tar.gz

Start at 0 and increment as needed.

In libxfce4util:

-License: BSD
+License: BSD LGPL

Can you change that to BSD and LGPL (its not a true dual license, your
clarification in the %changelog is good).

xfce4, xffm, xfprint, xfwm4, (and others?) seem to have lost %find_lang
%{name}. Is it no longer properly internationalized in 4.2.*?
(This seems to be a regression of
https://bugzilla.redhat.com/beta/show_bug.cgi?id=124954)

Note to new packagers: You should be using: 
%find_lang %{name} 
(in %{install})
and
%files -f %{name}.lang
(instead of just %files)

to package locales properly, not with:

%{_datadir}/locale/*/*/

Kevin, please run through all your srpms and make sure that %find_lang
is being used where relevant.

xffm-icons seems to be missing altogether. If its been sucked into the
main xffm package, please add this to the xffm spec:

Provides: xffm-icons = %{version}-%{release}
Obsoletes: xffm-icons <= 4.0.(whatever the last xffm-icons package released was)

xfprint, gtk-xfce-engine, and xfwm4 (and any others I might have
missed): drop the INSTALL from %doc, it wastes space (assuming that it
is the cookie cutter INSTALL file, if not, it can stay).

All packages: Be consistent with naming and case inside spec (with
exception of package names). Sometimes, its "XFce", sometimes "Xfce",
other times "xfce". The website says "Xfce", you should probably use
that.

xfwm4-themes:

-Summary: Themes for xfwm4
+Summary: Additionnal themes for xfwm4

Spell-check, please. "Additional". :)

Terminal:

"...with some new ideas and features that makes it unique among X
terminal emulators" (change "makes it" to "make it")

All packages (with libraries):

If the package is adding new libraries on install (or removing old
libraries on uninstall/upgrade), you need to have:

%post -p /sbin/ldconfig

%postun -p /sbin/ldconfig

Check your packages, I don't see these being used anywhere.

xffm:

You're missing a patch that Fedora Core had in the 4.0 series, that
still seems relevant in 4.2. (forgive the whitespace mangling)

xffm-4.0.5-rpath.patch

--- xffm-4.0.5/configure.orig 2004-05-13 14:42:21.764371688 +0200
+++ xffm-4.0.5/configure 2004-05-13 14:44:42.109609434 +0200
@@ -35263,7 +35263,7 @@
 
             echo "$as_me:$LINENO: checking DBH_LIBS" >&5
 echo $ECHO_N "checking DBH_LIBS... $ECHO_C" >&6
-            DBH_LIBS=`$PKG_CONFIG --libs "dbh-1.0 >= 1.0"`
+            DBH_LIBS=`$PKG_CONFIG --libs-only-l "dbh-1.0 >= 1.0"`
             echo "$as_me:$LINENO: result: $DBH_LIBS" >&5
 echo "${ECHO_T}$DBH_LIBS" >&6
         else

....

It might seem like a lot, but the packaging looks pretty good, aside
from the relatively minor issues I caught in initial review. Make the
changes, post them again, I'll eyeball once more, then do build testing.
If all continues to go well, you've got yourself a sponsor. :)

Thanks for taking the time to package this,

~spot
---
Tom "spot" Callaway: Red Hat Sales Engineer || GPG Fingerprint: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!