libgoffice spec file

[Michael A. Peters]

On Sun, 2005-11-06 at 18:06 -0600, Michael D. Wise wrote:
> I would like to submit libgoffice eventually but I have a couple of
> problems.  First I'm not sure about the spec file and locales.

Fedora ships with a macro just for locales

in the %install section sometime after install - use

%find_lang goffice

Then in %files - do

%files -f goffice.lang

> I've attached the spec file.  Any help would be appreciated.

1) Drop the explicit Requires on main package
rpm will figure them out based upon the shared libraries your binaries
need.

2) Reduce the BuildRequires - some of them are redundant (IE already
required by other BuildRequires)

3) Remove %{_libdir}/*.la
Extras does not package .la files. You should remove them in the %
install section - after the make install - via

find %buildroot%_libdir -type f -name "*.la" -exec rm -f {} ';'

4) Your devel package probably has too many explicit requires some of
which are redundant (ie one already requires another) - it really only
should require packages specified in its pkgconfig file.

-=-
There may be other things too.

-=-
As far as a place to host the spec file and src.rpm so that you can file
a bugzilla for a formal review - I unfortunately can't help you there.