[Bug 168630] Review Request: man-apropos2

[Michael Schwendt]

On Sun, 18 Sep 2005 14:57:59 -0400, Tony Nelson wrote:

> >* %clean section is good (I've never seen --preserve-root used in a spec file,
> >but that isn't a problem in my opinion).
> 
> This is something I would like additional opinions on.  It seems like a
> good idea (it avoids disaster if BuildRoot is /), but I don't know if
> --preserve-root is widely available enough.

This conversation should happen with complete quotes or within bugzilla.

In the somewhat cut context of above quote, buildroot==/ checks in %clean
only decrease readability of the spec file. Protection? No. You define a
sane BuildRoot at the top of the file. And so many src.rpms do not even
try to protect against any disasters, it would be _very_ unlikely that
somebody overrides the default buildroot and sets it to / regularly. FWIW,
in times of a mandatory buildroot definition, has anyone ever seen anybody
setting buildroot to / and running into problems? I highly doubt that.  Do
yourself a favour and drop such checks. They don't add any value at all.