[Bug 168630] Review Request: man-apropos2

[Tony Nelson]

At 2:24 PM -0400 9/18/05, bugzilla at redhat.com wrote:

Comments on the list, as they aren't about actual problems with the package.


>------- Additional Comments From chris at chrisgrau.com  2005-09-18 14:24 EST
>-------
>Review:

Thank you, Chris.


>$ rpmlint man-apropos2-1.0.1-2.noarch.rpm
>E: man-apropos2 script-without-shellbang /etc/profile.d/apropos2.csh
>E: man-apropos2 script-without-shellbang /etc/profile.d/apropos2.sh
>
>I don't see a problem here.  I checked a couple other scripts in
>/etc/profile.d
>and they don't have shellbangs either.  This makes sense, given how these
>files
>are sourced.

That's my thought, esp. as the shellbang would not be respected when the
script is sourced.  ISTM that shellbangs here would be like incorrect
comments in source code, and therefore bad style.  Comments?


>* %clean section is good (I've never seen --preserve-root used in a spec file,
>but that isn't a problem in my opinion).

This is something I would like additional opinions on.  It seems like a
good idea (it avoids disaster if BuildRoot is /), but I don't know if
--preserve-root is widely available enough.
____________________________________________________________________
TonyN.:'                       <mailto:tonynelson at georgeanelson.com>
      '                              <http://www.georgeanelson.com/>