[Bug 168608] Review Request: emelFM2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: emelFM2


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=168608


gauret at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |gauret at free.fr
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From gauret at free.fr  2005-09-25 11:24 EST -------
- Both patches contain hardcoded paths (/usr/share in patch0 and /usr in
patch1). It has to be %{_datadir} and %{_prefix} respectively. You could for
example use %DATADIR% and %PREFIX% in your patches and do sed substitution in
%prep to set the right path.
- In the specfile, you defined the patches names with %{version} included. It is
going to cause trouble on the next package update. You'd better replace it with
0.1.2.
- In %install, you use %{prefix}. It should be %{_prefix} (with underscore)
- The package sould own %{_libdir}/%{name} and %{_datadir}/pixmaps/%{name}


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.