[Bug 166414] Review Request: grace (Numerical Data Processing and Visualization Tool)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: grace (Numerical Data Processing and Visualization Tool)


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=166414


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|gdk at redhat.com              |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-01-09 09:52 EST -------
I made a patch to put conf files in /etc. 
I also modified the license such that it is only GPL and not BSD/GPL as BSD/GPL
could be interpreted as if it was dual licenced and it is not the case. I added
a comment to explain that Xbae is BSD and cephes is LGPL.

With that patch applied here is the review:

- rpmlint gives:
W: grace dangling-symlink /usr/share/grace/bin /usr/bin
W: grace symlink-should-be-relative /usr/share/grace/bin /usr/bin
W: grace-devel dangling-symlink /usr/share/grace/lib /usr/lib
W: grace-devel symlink-should-be-relative /usr/share/grace/lib /usr/lib
W: grace-devel dangling-symlink /usr/share/grace/include /usr/include
W: grace-devel symlink-should-be-relative /usr/share/grace/include /usr/include

this should be ignored
- package name follows the guidelines
- spec file is grace.spec
- package meets the packaging guidelines
- licences are compatible with fedora extras, licence files are included
- licence (GPL) matches the package licence
- spec is in legible american english
- sources match upstream
- builds in FC-4 mock
- right BuildRequires
- no shared libs
- not relocatable
- owns all the non FHS directories
- no duplicate in %files
- correct defattr
- rm -rf %{buildroot} in %clean
- consistent use of rpm macros
- no need to split doc to another package
- docs don't affect runtime
- headers and static libs in a devel subpackage
- use a fully versionned Requires for base package in devel package
- desktop file is present

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.