[Fedora-livecd-list] RE: Patches on Error Case, Error Message Print Out

[Jeremy Katz]

On Thu, 2007-03-08 at 12:06 +0100, Alexandre Magaz Graça wrote:
> I'm also having the same problem with Fedora 7. It complains about 
> duplicated repo and leaves mounted loop device.

Can you get a better trace of where it's complaining?

> While debugging the problem I noticed some possible bugs. So I attach
> a patch trying to fix the problem.
[snip]
> @@ -432,6 +436,11 @@ class InstallationTarget:
>      def teardown(self):
>          """releases all resources and removes all temporary files"""
>  
> +        self.bindmounts.reverse()
> +
> +        for bindmount in self.bindmounts:
> +            bindmount.umount()
> +
>          # ensure we've detached the install_root
>          self.unmount()

This doesn't quite seem right as we should be getting the bind mounts
unmounted when going to do the unmount() -- if you're not seeing that,
then the question is why not

Jeremy