[Fedora-livecd-list] RE: Patches on Error Case, Error Message Print Out

[Alexandre Magaz Graça]

Jeremy Katz escribió:
> On Thu, 2007-03-08 at 12:06 +0100, Alexandre Magaz Graça wrote:
>> I'm also having the same problem with Fedora 7. It complains about 
>> duplicated repo and leaves mounted loop device.
> 
> Can you get a better trace of where it's complaining?

Yes, here is the trace

Traceback (most recent call last):
   File "/usr/bin/livecd-creator", line 842, in main
     target.addRepository(n, u)
   File "/usr/bin/livecd-creator", line 457, in addRepository
     self.ayum.addRepository(name, url)
   File "/usr/bin/livecd-creator", line 240, in addRepository
     self.repos.add(repo)
   File "/usr/lib/python2.5/site-packages/yum/repos.py", line 44, in add
     raise Errors.DuplicateRepoError, 'Repository %s is listed more than 
once in the configuration' % (repoobj.id)
DuplicateRepoError: Repository extras is listed more than once in the 
configuration

Although I've tried with the last git version and now it doesn't 
complains anymore.

>> While debugging the problem I noticed some possible bugs. So I attach
>> a patch trying to fix the problem.
> [snip]
>> @@ -432,6 +436,11 @@ class InstallationTarget:
>>      def teardown(self):
>>          """releases all resources and removes all temporary files"""
>>  
>> +        self.bindmounts.reverse()
>> +
>> +        for bindmount in self.bindmounts:
>> +            bindmount.umount()
>> +
>>          # ensure we've detached the install_root
>>          self.unmount()
> 
> This doesn't quite seem right as we should be getting the bind mounts
> unmounted when going to do the unmount() -- if you're not seeing that,
> then the question is why not

Oops!! you are right, I didn't see it

> Jeremy
>  
> 
> --
> Fedora-livecd-list mailing list
> Fedora-livecd-list at redhat.com
> https://www.redhat.com/mailman/listinfo/fedora-livecd-list