[Fedora-livecd-list] [PATCH] added get_partitions to kickstart.py

Jeremy Katz katzj at redhat.com
Mon Jul 14 20:27:44 UTC 2008


So, generally looking okay from the look I did.  Two big little things
left that I see

1) Commit messages should be more than one-liners.
http://www.tpope.net/node/106 actually has a really nice description of
what makes a good commit message
2) Instead of funky formatting of comments, just use the standard pydoc
""" -- it'll also mean that we can extract api information and use
help() if you're using the python interpreter on the command-line

Jeremy




More information about the Fedora-livecd-list mailing list