[Bug 189315] Review Request: ardour

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ardour


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189315





------- Additional Comments From andy at smile.org.ua  2006-04-19 05:19 EST -------
Briefly check of spec file gives following remarks:
 - why do you not use %find_lang macro?
 - ardor needs own the /etc/ardour/ (and may be use %{_sysconfdir} instead of /
etc)
 - differnet style of build root definition (%buildroot vs. $RPM_BUILD_ROOT and 
 %{buildroot}%{_other_macro} vs. %{buildroot}/%{_other_macro})
 - buildrequires overhead (gcc-c++, flex and so on. See packaging guidelines)
 - more preferable to put full URL instead of name-version in Source: parameter
 - I don't know about noreplace feature in %config. Possible you need it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.