[Bug 189315] Review Request: ardour

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ardour


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189315





------- Additional Comments From green at redhat.com  2006-04-19 13:27 EST -------
(In reply to comment #3)
> Briefly check of spec file gives following remarks:
>  - why do you not use %find_lang macro?

How do I use this?  There are .mo files with different names (gtk_ardour.mo,
libardour.mo, etc).

>  - ardor needs own the /etc/ardour/ (and may be use %{_sysconfdir} instead of /
> etc)

Done.

>  - differnet style of build root definition (%buildroot vs. $RPM_BUILD_ROOT and 
>  %{buildroot}%{_other_macro} vs. %{buildroot}/%{_other_macro})

Fixed.

>  - buildrequires overhead (gcc-c++, flex and so on. See packaging guidelines)

Removed gcc-c++.  I believe flex is required.

>  - more preferable to put full URL instead of name-version in Source: parameter

Fixed.

>  - I don't know about noreplace feature in %config. Possible you need it.

Added.

Thanks!




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.