[Bug 175047] Review Request: NetworkManager-openvpn

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: NetworkManager-openvpn


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=175047





------- Additional Comments From jeff at ollie.clive.ia.us  2006-08-07 23:26 EST -------
The URL tag is required... It should probably point to
<http://www.gnome.org/projects/NetworkManager/>.  It's not a link to the source.

Since you are using a CVS snapshot, you should include comments on how to
recreate the snapshot.  Also, since this is a CVS snapshot "autogen.sh" has
never been run before.  This script requires gnome-common, automake, autoconf,
libtool, and intltool none of which are available by default in the FE build
system.  So you'd either need to BuildRequire them, or run autogen.sh manually
in the directory before you create the tarball.  I'd go with the 2nd option...
it'll keep things cleaner.

Other than that it seems to build fine.

Creating a VPN connection seemed worked fine (the mouse on this laptop is
getting flaky so I'm sure any difficulty I had was due to that), other than the
known problem with VPN connections not showing up until you restart the
NetworkManager applet.

However, when I actually tried to connect to the new VPN connection I made,
SELinux threw a fit:

kernel: audit(1155005417.964:12): avc:  denied  { execute } for  pid=2924
comm="nm-openvpn-serv" name="openvpn" dev=dm-0 ino=758428
scontext=user_u:system_r:NetworkManager_t:s0
tcontext=system_u:object_r:openvpn_exec_t:s0 tclass=file

This would sometimes cause the NetworkManager daemon to crash:

NetworkManager: file nm-vpn-service.c: line 459
(nm_vpn_service_stage3_connect_cb): assertion failed: (service != NULL)

(BTW, I'm testing with NetworkManager 0.6.4 from FC5).

For purposes of testing, I disabled SELinux for NetworkManager by changing the
NetworkManager_disable_trans SELinux boolean variable.  Before this package gets
accepted a more permanent solution needs to be found.

Once the SELinux problems were bypassed the VPN connection seemed to work fine.
 I couldn't check for sure because I was connecting to my home VPN server from
inside my home network.  Once I'm back at work tomorrow I check that out for sure.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.