[Bug 191017] Review Request: eclipse-subclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-subclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191017


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(robert at marcanoonli|
                   |ne.com)                     |




------- Additional Comments From tibbs at math.uh.edu  2006-08-24 00:46 EST -------
Things look very good and I will work up a full review tomorrow, but I wanted to
comment on one thing:

> All eclipse related RPMs package dependencies as absolute links, i just did the
> same.

Given the state of many core packages, unless you can point to an Extras-style
review then pointing to what an existing package does is not generally a valid
argument.

Still, in this case I asked around and the issue of the
symlink-should-be-relative warning is not clear cut.  The main reason for the
warning is the fact that absolute symlinks get in the way of proper operation
with chroots (since the links will point to different files depending on whether
you've chrooted or not).  Symlinks can have this problem too if they contain
excessive ".." components, but hopefully that would be caught in a review.

So I tend to believe that it would be better to use relative symlinks, but it's
not really essential for a desktop application and in this case the rest of
eclipse is bound to have the same issue.  I won't block on it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.