[Bug 191017] Review Request: eclipse-subclipse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: eclipse-subclipse


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191017


tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From tibbs at math.uh.edu  2006-08-25 00:50 EST -------
I had to chase dependencies a bit to make sure that %libdir/gjc is properly
owned, but I'm pretty sure it is.  I wish there was a handy recursive dependency
chaser.

* source files match upstream.
   (No checksums possible; see above.  Comparison using diff shows the source to
be identical.)
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate (as far as I can tell for Java)
* %clean is present.
* package builds in mock (development, x86_64).
* debuginfo package looks complete (no source, but there are debug symbols).
* rpmlint complaints are acceptable.
* final provides and requires are sane:
  eclipse-subclipse-1.1.5-1.fc6.x86_64.rpm
   org.tigris.subversion.subclipse.ui_1.1.5.jar.so()(64bit)
   subclipse-core.jar.so()(64bit)
   svnClientAdapter.jar.so()(64bit)
   eclipse-subclipse = 1.1.5-1.fc6
  =
   /usr/bin/rebuild-gcj-db
   eclipse-platform
   ganymed-ssh2 >= 209
   java-gcj-compat >= 1.0.33
   javasvn >= 1.1.0
   libgcj_bc.so.1()(64bit)
   librt.so.1()(64bit)
   libz.so.1()(64bit)
   subversion-javahl >= 1.3.1

  eclipse-subclipse-book-1.1.5-1.fc6.x86_64.rpm
   eclipse-subclipse-book = 1.1.5-1.fc6
  =
   eclipse-subclipse = 1.1.5-1.fc6

* %check is not present; no test suite upstream.
* no shared libraries are added to the regular linker search paths.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets present (rebuild-gcj-db) are OK.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.  The subversion
book is provided as an eclipse plugin in a separate package.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.