[Bug 217998] Review Request: alfont - Font rendering library for the Allegro game library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: alfont - Font rendering library for the Allegro game library
Alias: alfont

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=217998


chris.stone at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |chris.stone at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |
              Alias|                            |alfont




------- Additional Comments From chris.stone at gmail.com  2006-12-01 12:01 EST -------
==== REVIEW CHECKLIST ====
O rpmlint output:

PRE-INSTALL:
W: alfont-devel no-documentation

POST-INSTALL:
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 ugetc
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 ugetxc
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 getg
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 uvszprintf
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 getb
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 destroy_bitmap
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 getr
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 set_uformat
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 set_trans_blender
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 get_uformat
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 masked_blit
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 create_bitmap_ex
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 solid_mode
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 need_uconvert
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 makecol
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 drawing_mode
W: alfont undefined-non-weak-symbol /usr/lib64/libalfont.so.2.0.6 ustrlen

post-install rpmlint warnings must be investigated

- package named according to package naming guideliens
- spec file name matches %{name}
- meets packaging guidelines
- licensed with open source compatible license
- license matches actual license
- license included in %doc
- spec written in American english
- spec legible
- sources match upstream (unrared upstream and untarred sources and ran diff on
output:
diff -ubBr alfont-2.0.6 AlFont
(no output)
- package successfully compiles and builds on FC6 x86_64
- all dependencies listed in BR
- no locales
- proper %post/un sections
- package is not relocatable
- package owns all directories it creates
- file permissions set properly
- contains proper %clean section
- macro usage consistent
- contains code
- no large documentation
- %doc does not affect runtime
O header files in devel package
  devel package contains strange header file which looks like a windows version
- no pkgconfig files
- libs w/o suffix in devel
- devel package requires main package
- no .la files
- not a GUI app needing a .desktop file
- does not own files or directories owned by other packages

==== MUST FIX ====
- Investigate rpmlint warnings
- Why is /usr/include/alfont.h.linux in devel package?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.