[Bug 218176] Review Request: gchempaint - A 2D chemical formulae drawing tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gchempaint - A 2D chemical formulae drawing tool


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218176


mtasaka at ioa.s.u-tokyo.ac.jp changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-05 12:44 EST -------
Some comments from me.

>From http://fedoraproject.org/wiki/Packaging/Guidelines :
* Use rpmlint
------------------------------------------------------
W: gchempaint non-conffile-in-etc /etc/gconf/schemas/gchempaint-arrows.schemas
W: gchempaint macro-in-%changelog files
W: gchempaint-devel no-documentation
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
g_printable_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rich_text_ext_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rich_text_ext_set_buffer
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rich_text_ext_get_iter_location
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rich_text_ext_get_buffer
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_text_ext_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_ellipse_ext_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_bpath_ext_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rich_text_ext_get_pango_layout
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
g_printable_export_svg
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rich_text_ext_get_iter_at_location
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_group_ext_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_rect_ext_get_type
W: gchempaint undefined-non-weak-symbol /usr/lib/libgchempaint.so.0.6.6
gnome_canvas_line_ext_get_type
------------------------------------------------------
- non-conffile-in-etc warning can be ignored. gconf schemas 
  files are not config file.
- When you want to use percent in %changelog, please use %%.
- Well, for undefined non-weak symbols issue:
  Some reviewers say this can be ignorable for Review, while 
  some reviewers say they should be fixed before approving the package.

  For this package, libgchempaint.so is included in -devel package so
  leaving these undefined symbols causes failure for linking to
  libgchempaint.so, so this should be fixed before this package is
  approved.

  Then:
  1. for g_printable_get_type and g_printable_export_svg:
     This is defined in ./libgcpcanvas/gprintable.c, however
     gprintable.o is not used in libgchempaint.so.0.6.6 so this
     is actually wrong (this should cause failure linkage).
  2. for gnome_canvas_... :
     Perhaps linking libgchempaint.so to libgnomecanvas-2.so
     (in libgnomecanvas-devel) will fix these complaint.

* Requires
  pkgconfig (in -devel)
  - It seems that -devel package does not includes pkgconfig .pc file.

* File and Directory Ownership
  - /usr/share/omf/gchempaint/ is not owned by any package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.