[Bug 218408] Review Request: xl2tpd - replacement of l2tpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xl2tpd - replacement of l2tpd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218408





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2006-12-06 11:52 EST -------
Well,

* Please keep timestamps, as I said in comment #7 and the section
  'timestamps' in http://fedoraproject.org/wiki/Packaging/Guidelines
  Please use 'install -p'. Timestamps should be changed when the
  contents of the files are actually changed, this should be especially
  for text files.

  (In reply to comment #5)
* I still get the rpmlint complaint:
------------------------------------------
E: xl2tpd no-chkconfig-line /etc/rc.d/init.d/xl2tpd
------------------------------------------
> 4. : This error can be suppressed by replacing tab with space
>      in '# chkconfig:    - 80 30' line.
Well, what I wanted to say by this is: "please use space in 
'#chkconfig: - 80 30' line, not tab.

> B. http://fedoraproject.org/wiki/Packaging/ScriptletSnippets :
> * Initscripts Conventions
>   - Please add the appropriate requirement in
>     Requires(post), etc.
Well, requirement for /sbin/service is still missing

(In reply to comment #6)
> 3 I've tested migration and the order is correct. the orignally installed
>   xl2tpd configs are kept as rmpsave files, the ones from /etc/l2tpd/ are
>   migrated into /etc/xl2tpd/, and then l2tpd gets uninstalled, and creates
>   its own rpmsave files if needed.

I still have a concern about the case in which some people may
customize original l2tpd rpm and reinstall it with release number
incremented by themself.
In this case, l2tpd is not uninstalled, which is correct that 
customizing by themself means that they don't want to have l2tpd
automatically removed by xl2tpd. However, current %post scripts
anyway 'moves' files in l2tpd, then l2tpd is installed with some
files missing.

And... I don't know about l2tpd, however, if removing l2tpd is
done after installing x12tpd, then there arises a moment anyway 
when l2tpd is installed while some files in l2tpd is missing.
In the case uninstalling l2tpd exits with non-zeron status and
it won't be completed.

This state is critical when these files are 'required' for 
uninstalling l2tpd. Even if not, removing files in l2tpd should
be done when l2tpd is exactly about being removed.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.