[Bug 218408] Review Request: xl2tpd - replacement of l2tpd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xl2tpd - replacement of l2tpd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=218408





------- Additional Comments From paul at xelerance.com  2006-12-06 15:59 EST -------
spec URL: ftp://ftp.xelerance.com/xl2tpd/xl2tpd.spec
SRPM URL: ftp://ftp.xelerance.com/xl2tpd/xl2tpd-1.1.06-4.src.rpm

- I still prefer to see the build timestamps compared to the original tar ball
  timestampts. But I added -p, beacause I just want to get over this.
- the space vs tab issue was still there because that error is in the original
  tarball. I dont want to release the usptream version just for this, so I
  added a temp sed line to the install process.
  writing a patch to just cover a week before that release seems a bit overkill.
- Added /sbin/service requirement.
- as for the "mv". Please give me another method to distinguish between an
upgrade from l2tpd->xl2tpd and one from xl2tpd->xl2tpd. AFAIK, I cannot tell in
any scriplets. If I use "mv", the migration will not happen more then once. If I
use "cp", it will be possible to happen more then once. Alternatively, if you
are that worried I can leave out the entire migration and let users do it
manually, but then it will surely need human intervention after installing the
upgrade.

AS for your last notes, as I told before, there are NO errors when doing an
l2tpd -> xl2tpd upgrade. l2tpd uninstalls fine. xl2tpd installs fine. Please
test if you do not believe me.

What's left now is:
[root at bofh devel]# rpmlint /usr/src/redhat/RPMS/x86_64/xl2tpd-1.1.06-4.x86_64.rpm
E: xl2tpd non-readable /etc/xl2tpd/l2tp-secrets 0600
E: xl2tpd non-readable /etc/ppp/chap-secrets.sample 0600
W: xl2tpd dangerous-command-in-%post mv
[root at bofh devel]# rpmlint /usr/src/redhat/SRPMS/xl2tpd-1.1.06-4.src.rpm 

the secrets are supposed to be root-only readable.
the "mv" is discussed above.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.