[Bug 196393] Review Request: svrcore-devel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: svrcore-devel
Alias: svrcore-devel

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196393





------- Additional Comments From toshio at tiki-lounge.com  2006-12-08 03:08 EST -------
http://www.tiki-lounge.com/~toshio/fedora/svrcore-4.0.2.01-0.src.rpm

Initial work to port this to autotools.
There's a tarball and x86_64 rpms in that directory as well.  Please be warned
that I am pretty good with autotools but I don't know svrcore or the netscape
build system at all.  I have no programs to test this against.  Therefore, this
could be totally borked (most likely, borked on certain archs but not other as
replacing the buildsystem usually hits portability hacks).

That said, here's the status as I currently see it:
* New layout.  The tarball contains two directories.  svrcore-VERSION/ with
supporting files (README, LICENSE, etc) and svrcore-VERSION/src with the source
code.
* Autotools configures and builds shared and static libraries on linux-x86_64.
* Autotools take care of generating the pkgconfig file as well.
* Running make distcheck passes and creates distribution tarballs.
* Cleaned up the rpm spec file a bit for the new build system.  Commented a
bunch of the env variable defining as I've only done an initial read through to
figure out if it was necessary.
* Documentation needs to be updated: NEWS, AUTHORS, and ChangeLog are new files
that can be filled with useful information :-)  INSTALL needs to be updated with
the new install proceedures.
* configure.ac has an email address for bug reports in one of its macros.  Just
need to replace what's there with the proper address.
* I don't have a Windows box so I don't know how autotools works on Windows (or
if this is something you place a high priority on.)
* I need to run ifnames on the source files and figure out where all the cpp
variables get set.  Most of them looked Windows specific so there's a high
probablility things work on *nix boxes but not Windows.  We need to figure out
hy these defines are set and implement tests in configure.ac to set them
instead.  This is where talkign with someone who understands svrcore/coreconf
would be helpful.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.