[Bug 219932] Review Request: driconf - A configuration applet for the Direct Rendering Infrastructure

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: driconf - A configuration applet for the Direct Rendering Infrastructure


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219932





------- Additional Comments From kevin at tummy.com  2006-12-18 14:57 EST -------
Both issues fixed. 

Spec URL: http://www.scrye.com/~kevin/fedora-extras/driconf.spec
SRPM URL: http://www.scrye.com/~kevin/fedora-extras/driconf-0.9.1-3.fc7.src.rpm

diff of spec: 

--- driconf.spec-2      2006-12-16 20:31:44.000000000 -0700
+++ driconf.spec        2006-12-18 12:55:27.000000000 -0700
@@ -2,7 +2,7 @@
 
 Name:           driconf
 Version:        0.9.1
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        A configuration applet for the Direct Rendering Infrastructure
 
 Group:          User Interface/X
@@ -12,7 +12,8 @@
 Patch1:         driconf-0.9.1-setup.patch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
-BuildRequires:  pygtk2-devel
+BuildRequires:  python-devel
+BuildRequires:  desktop-file-utils
 BuildArch:      noarch
 Requires:      pygtk2
 Requires:      glx-utils
@@ -40,9 +41,29 @@
 
 %find_lang driconf
 
+cat << EOF > %{name}.desktop
+[Desktop Entry]
+Name=Driconf
+Comment=configuration applet for the Direct Rendering Infrastructure
+Exec=/usr/bin/driconf
+Icon=/usr/share/driconf/driconf-icon.png
+Terminal=false
+Type=Application
+Encoding=UTF-8
+Categories=Application;X-Fedora;
+EOF
+
+desktop-file-install --vendor fedora \
+        --dir $RPM_BUILD_ROOT/%{_datadir}/applications/ %{name}.desktop
+
 %clean
 rm -rf $RPM_BUILD_ROOT
 
+%post
+update-desktop-database > /dev/null 2>&1 || :
+
+%postun
+update-desktop-database > /dev/null 2>&1 || :
 
 %files -f driconf.lang
 %defattr(-,root,root,-)
@@ -69,8 +90,13 @@
 %{_datadir}/driconf/screen.png
 %{_datadir}/driconf/screencard.png
 %{_datadir}/driconf/driconf-icon.png
+%{_datadir}/applications/*.desktop
 
 %changelog
+* Mon Dec 18 2006 Kevin Fenzi <kevin at tummy.com> - 0.9.1-3
+- Changed pygtk2-devel BuildRequires to python-devel
+- Added desktop file. 
+
 * Sat Dec 16 2006 Kevin Fenzi <kevin at tummy.com> - 0.9.1-2
 - Added Requires for pygtk2 and glx-utils


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.