[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





------- Additional Comments From kevin at tummy.com  2006-12-22 00:17 EST -------

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (GPL)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
284e26595637dd2e900b75534372496b  xfce4-smartbookmark-plugin-0.4.2.tar.gz
284e26595637dd2e900b75534372496b  xfce4-smartbookmark-plugin-0.4.2.tar.gz.1
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.

See below - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
See below - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock.
OK - Should build on all supported archs
OK - Should have dist tag
OK - Should package latest version

Issues:

1. Whats with the commented line in the files section?
#%{_libexecdir}/xfce4/panel-plugins/%{name}

2. Your desktop file needs desktop-file-install:
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

3. This package provides:
libsmartbookmark.so
Is that correct? Or should that be filtered?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.