[Bug 219986] Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xfce4-smartbookmark-plugin - Smart bookmarks for the Xfce panel


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219986





------- Additional Comments From fedora at christoph-wickert.de  2006-12-22 08:14 EST -------
(In reply to comment #2)
> Issues:
> 
> 1. Whats with the commented line in the files section?
> #%{_libexecdir}/xfce4/panel-plugins/%{name}

This is the new location of xfce4-panel plugins. Hopefully with the next version
 libsmarbookmark.so will be moved from %{_libdir}/xfce4/panel-plugins to
%{_libexecdir}/xfce4/panel-plugins. When all panel plugins are _fully_ ported to
the new panel plugin API you can drop %{_libdir}/xfce4/panel-plugins from you
xfce4-panel package.

> 2. Your desktop file needs desktop-file-install:

Really? I always thought this was only for applications that show up in the main
menu. This desktop file only appears in the "Add Items to the Panel" dialog. I
think in this case there's not need to install the file with
desktop-file-install, because we don't need to modify it (--add-category,
--vendor etc.).

Think of your xfce-utils package, which installs xfce4.desktop in
/usr/share/xsessions or of all the files installed under /etc/xdg/autostart by
xfce4-session and others. None of these packages uses desktop-file-install.

> 3. This package provides:
> libsmartbookmark.so
> Is that correct? Or should that be filtered?

IMO it is correct, but useless.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.