[Bug 209214] Review Request: libprelude - Prelude library collection

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libprelude - Prelude library collection


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=209214





------- Additional Comments From rc040203 at freenet.de  2006-12-22 01:27 EST -------
(In reply to comment #15)

> * moved config to /etc/prelude instead of /etc/prelude/prelude
Well, did you?
# rpm -qlp libprelude-0.9.12-1.i386.rpm | grep /etc/prelude
/etc/prelude
/etc/prelude/prelude
/etc/prelude/prelude/default
/etc/prelude/prelude/default/client.conf
/etc/prelude/prelude/default/global.conf
/etc/prelude/prelude/default/idmef-client.conf
/etc/prelude/prelude/default/tls.conf
/etc/prelude/prelude/profile

Further issues:

- The perl modules are being installed into site_perl
# rpm -qlp libprelude-devel-0.9.12-1.i386.rpm | grep perl5
/usr/lib/perl5/5.8.8/i386-linux-thread-multi/perllocal.pod
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/Prelude.pm
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Prelude
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/.packlist
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.bs
/usr/lib/perl5/site_perl/5.8.8/i386-linux-thread-multi/auto/Prelude/Prelude.so

Fedora supplied perl-modules MUST go into vendor_perl (or outside of the perl5/
hierarchy). Installing into site_perl is a no-no.

- The perl-module contains files supposed not to be shipped (.packlist, etc.)
You might want to check how perl modules are suppose to be packaged in FE.

- Package must not own /usr/share/aclocal
# rpm -qlp libprelude-devel-0.9.12-1.i386.rpm | grep aclocal
/usr/share/aclocal
/usr/share/aclocal/libprelude.m4

The FPC has not decided upon yet, but so far the recommendation is to requires
packages providing aclocal macros to 
Requires: automake

- I don't understand why the perl-module is part of *-devel.
Perl modules normally all are run-time packages.

- I'd split the language bindings into separate packages (esp. move the perl
module into a separate perl-Prelude package). This would avoid pulling in
unnecessary deps in cases users are only interested into one of the language
bindings.

I am not sufficiently familiar with python, but I presume similar consideration
as to the perl bindings also apply to it (Toshio, Ville, f13?)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.