[Bug 220969] Review Request: isomaster - GUI CD image editor

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 30 11:28:48 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: isomaster - GUI CD image editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220969





------- Additional Comments From mszpak at wp.pl  2006-12-30 06:28 EST -------
(In reply to comment #3)
> Remember that %install section is executed at building an SRPM, not at
> installing the binary one. That's why you need to put it into BR.

Sure, it was logical mistake.

> Desktop files aren't as large to put them into tarball. You can remove a tar
> compression and get rid of second %setup macro. Now, you can put %{SOURCE1}
> macro into desktop-file-install:
> desktop-file-install --vendor fedora \
> 	--dir %{buildroot}%{_datadir}/applications \
> 	%{SOURCE1}

Yesterday I remembered why I had switched to generated .desktop files. In
prebuilt .desktop file there has to be fixed path to icon which can be incorrent
if package isn't installed in /usr. 
But it isn't probably a common problem.

> and it looks much better :)

Hopefully good enough to find a sponsor :)

Updated version:
http://timeoff.wsisiz.edu.pl/zrzut/isomaster.spec
http://timeoff.wsisiz.edu.pl/zrzut/isomaster-0.6-4.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list