[Bug 220969] Review Request: isomaster - GUI CD image editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: isomaster - GUI CD image editor


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220969





------- Additional Comments From mr.ecik at gmail.com  2006-12-30 11:35 EST -------
I tried to run rpmlint for your newest package and I got:
E: isomaster description-line-too-long ISO Master: an easy to use GUI CD image 
editor. It allows to extract files from an ISO, add files to an ISO, and create 
bootable ISOs - all in a graphical user interface.
E: isomaster description-line-too-long ISO Master: an easy to use GUI CD image 
editor. It allows to extract files from an ISO, add files to an ISO, and create 
bootable ISOs - all in a graphical user interface.
W: isomaster macro-in-%changelog _datadir

In order to get rid of the first two ones you have to split your %description.
One line inside it may be max 79 characters long.
To remove a warning just double % character, so instead of %{_datadir} write
%%{_datadir} etc.
Also I noticed that gtk2 dependency ought to be removed completely.
Running rpm -qpR for RPM gives me following result:
gtk2
libatk-1.0.so.0()(64bit)
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.3)(64bit)
libcairo.so.2()(64bit)
libdl.so.2()(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgmodule-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libm.so.6()(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rtld(GNU_HASH)

As you can see, there is libgtk-x11-2.0.so.0 file.
$ rpm -qf /usr/lib64/libgtk-x11-2.0.so.0
gtk2-2.10.4-4.fc6.x86_64

So it is owned by gtk2 package. It means you can remove that dependency without
concern.

(In reply to comment #4))
> Hopefully good enough to find a sponsor :)

It does look for me that if you fix the last issues I mentioned above, this
package surely will be good enough.
Remember to make unoffical reviews of another packages to let sponsors
pay attention to you ;-)


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.