[Bug 189886] Review Request: FluidSynth - Real-time software synthesizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: FluidSynth - Real-time software synthesizer


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189886





------- Additional Comments From green at redhat.com  2006-07-14 00:09 EST -------
(In reply to comment #3)
> 0 rpmlint output is:
> E: fluidsynth obsolete-not-provided iiwusynth
> E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel

Fixed.

> 0 License (LGPL) ok, but license file not included!

Fixed.

> 0 no %doc

Fixed.

> 0 .la files packaged, bad!

Fixed.

> * Alphanumeric parts of the version should be in the Release field, as per:
>  http://fedoraproject.org/wiki/Packaging/NamingGuidelines
>  Then you can drop the "-n fluidsynth-1.0.7" to %setup too

Fixed.

> * Dont use %package -n lib%{name} thats very Debian afaik (allmost) all Fedora
>   package use %package libs same goes for the devel package.

Fixed.

> * The following rpmlint output:
> E: fluidsynth obsolete-not-provided iiwusynth
> E: libfluidsynth-devel obsolete-not-provided libiiwusynth-devel
> * Don't package .la files, remove them under %install or %exclude them in %files
> * Add a %doc including atleast COPYING, but mosty likely also other candidates

Fixed, as above.

Thanks for your effort. Sorry for the delay.

Updates bits here:
Spec URL: http://people.redhat.com/green/FE/FC5/fluidsynth.spec
SRPM URL: http://people.redhat.com/green/FE/FC5/fluidsynth-1.0.7-5.a.src.rpm





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.