[Bug 193897] Review Request: mysql-connector-java - Official JDBC driver for MySQL

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: mysql-connector-java - Official JDBC driver for MySQL


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193897





------- Additional Comments From green at redhat.com  2006-07-26 10:26 EST -------
(In reply to comment #7)
> (In reply to comment #6)
> > X- macro use is fine apart from %{__sed}.  Please use "sed".
> 
> What's wrong with using %{__sed}?

I've been told not to use macros like %{__make}, %{__rm}, etc in reviews people
have done for me.  However, you're right, I don't see any ruling on this in the
FE package guidelines.  And, indeed, the %{__sed} magic I originally proposed
was directly from the FE packaging guidelines.  
Ok, ignore this comment.  %{__sed} is fine I guess.  
Thanks.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.