[Bug 197764] Review Request: hfsplus-tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hfsplus-tools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197764





------- Additional Comments From tibbs at math.uh.edu  2006-07-20 23:52 EST -------
rpmlint has this to say:

W: hfsplus-tools no-documentation
It looks like there are manpages in the tarball; any reason not to package them?

These are from executable source files.  Easily fixed with a quick chmod.
E: hfsplus-tools-debuginfo script-without-shellbang
/usr/src/debug/diskdev_cmds-332.11/fsck_hfs.tproj/dfalib/hfs_endian.h
E: hfsplus-tools-debuginfo script-without-shellbang
/usr/src/debug/diskdev_cmds-332.11/fsck_hfs.tproj/dfalib/hfs_endian.c
E: hfsplus-tools-debuginfo script-without-shellbang
/usr/src/debug/diskdev_cmds-332.11/fsck_hfs.tproj/dfalib/HardLinkCheck.c
E: hfsplus-tools-debuginfo script-without-shellbang
/usr/src/debug/diskdev_cmds-332.11/fsck_hfs.tproj/dfalib/SRebuildCatalogBTree.c
E: hfsplus-tools-debuginfo script-without-shellbang
/usr/src/debug/diskdev_cmds-332.11/fsck_hfs.tproj/dfalib/BTreeScanner.c
E: hfsplus-tools-debuginfo script-without-shellbang
/usr/src/debug/diskdev_cmds-332.11/fsck_hfs.tproj/dfalib/BTreeScanner.h

While it's true that the source is all under the APSL and that this package
doesn't actually include a copy, the APSL is sufficiently both different and
uncommon that I do think it would be a good idea to include it in the package. 
I couldn't find it directly in text form, but you can snip it from
http://www.opensource.apple.com/apsl/.

It doesn't look as if the compiler is being called with the proper flags.  The
gentoo patch sets up its own set of CFLAGS which are not the ones used in
Fedora.  I wonder if it works to delete CFLAGS from the Makefiles and then pass
them on the commandline.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.