[Bug 184450] Review Request: wcstools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wcstools


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184450





------- Additional Comments From paul at city-fan.org  2006-06-09 12:42 EST -------
Created an attachment (id=130829)
 --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=130829&action=view)
Enable use of custom CFLAGS

With the addition of this patch, the %build section of the script can be
changed to:

%{__make} CC=%{__cc} CFLAGS="%{optflags} -fPIC" all

and the package build honors %{optflags}

It also results in some "interesting" warning messages, such as:
catutil.c:750: warning: call to __builtin___strcpy_chk will always overflow
destination buffer
catutil.c:774: warning: call to __builtin___strcpy_chk will always overflow
destination buffer
imutil.c:648: warning: too few arguments for format
imutil.c:737: warning: too few arguments for format
imutil.c:824: warning: too few arguments for format
getdate.c:388: warning: call to __builtin___strcpy_chk will always overflow
destination buffer
simpos.c:191: warning: control reaches end of non-void function

Makes one wonder about the code quality...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.