[Bug 196281] Review Request: php-manual-en - English language PHP manual

bugzilla at redhat.com bugzilla at redhat.com
Thu Jun 22 13:43:04 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-manual-en - English language PHP manual


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196281


hugo at devin.com.br changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hugo at devin.com.br




------- Additional Comments From hugo at devin.com.br  2006-06-22 09:34 EST -------
(In reply to comment #0)
> W: php-manual-en invalid-license Open Publication License v1.0

Just "OPL" would be better?

> - Arguably the package should be php-manual-en-us, since in theory there
> might be an en_GB manual at some point, but I wonder whether this is going
> too far with the whole abstraction

Some other languages really requires the xx_YY naming... The package could 
contain php manuals from other languages too, don't you think? A source 
package could crate some packages, one for each language.

About the en vs. en-us, I think you should follow upstream on this. So 
only 'en' is IMO the right thing.

> - the Source URL is not really right for two reasons:
> 
> a) it has to have a silly /mirror/rubbish/junk on the end
> b) it doesn't include the version in it
> 
> but this is an upstream problem.

You should download and get the exact URL, for example:
http://us2.php.net/distributions/manual/php_manual_en.tar.gz



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list