[Bug 196281] Review Request: php-manual-en - English language PHP manual

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-manual-en - English language PHP manual


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196281





------- Additional Comments From rpm at timj.co.uk  2006-06-26 10:34 EST -------
> > W: php-manual-en invalid-license Open Publication License v1.0
> Just "OPL" would be better?

It doesn't include a version. We really ought to specify a version if the
package specifies one, because otherwise if there's (say) an OPL v3 in future
with different terms, we would be misleading users by implying they could
distribute it under the terms of OPL v3 whereas the authors might have only
specified OPL v1. We should respect the author's license. Note for example that
recent Core "php" packages have started explicitly mentioning license version.

That said, "OPL v1.0" is fine by me, but I'm pretty sure rpmlint doesn't know
that either and it's less descriptive.
 
> > - Arguably the package should be php-manual-en-us, since in theory there
> > might be an en_GB manual at some point, but I wonder whether this is going
> > too far with the whole abstraction
> Some other languages really requires the xx_YY naming... 

That's ok, they can name it "php-manual-pt-br" or whatever as necessary.

I could maybe make the current package Provide php-manual-en-us, for forward
compatibility in case it gets split in future. That would make sense.

> The package could contain php manuals from other languages too, don't you 
> think? 

Yes, but see linked thread: I don't want the responsibility of maintaining them.
Also if I included every language supplied by PHP then the source RPM would be
really huge.
Additionally in future it's possible that not all languages would get updated at
the same time, so it could in theory mean pushing a big update SRPM even though
many sources are unchanged.

> You should download and get the exact URL, for example:
> http://us2.php.net/distributions/manual/php_manual_en.tar.gz

Thanks, I didn't pick up on that direct URL.

Updated files:

Spec URL: http://www.timj.co.uk/linux/specs/php-manual-en.spec
SRPM URL: http://www.timj.co.uk/linux/srpms/php-manual-en-20060527-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.