[Bug 196057] Review Request: libhugetlbfs - easy access to huge pages of memory

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libhugetlbfs - easy access to huge pages of memory


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196057





------- Additional Comments From jwilson at redhat.com  2006-06-23 13:30 EST -------
Okay, so I've got the package building only the required binaries (no need for
%exclude), and the correct 32-bit glibc-devel dep figured out, as well as a few
minor tweaks to the spec file.

1) sub-package deps should be on %{version}-%{release}, not
%{libhugetlbfs_version}-%{release}

2) add  'BuildRequires: /usr/include/gnu/stubs-32.h' (without any %ifarch) to
make sure 32-bit glibc-devel gets pulled in (should work for ppc64 builds also)

3) you can pass LDSCRIPTDIR to make install to avoid having to move the scripts
later

4) just rm -f the .a files, using find is unnecessary

5) 32-bit ldscripts shouldn't get packaged on 64-bit builds

6) A roughly 6-line addition to the Makefile and an extra flag on the make lines
in the spec file eliminates the building of unneeded 32-bit parts on 64-bit
builds (its a little hacky, but works nicely)

Check out my diffs and resulting spec, srpm and tarball here:

http://wilsonet.com/packages/libhugetlbfs/

(I also tweaked the Makefile to put hugetlbd in sbin from the get go)

The srpm at the above URL builds quite nicely on FC5/x86_64 and in an FC5/i386
mock chroot, but is having issues in a mock FC5/x86_64 chroot, I believe due to
the default exclude flags (that mask out i386 packages)... Unfortunately, I
think they are the same on the extras build servers, so we're sort of stuck
again... :(

(Pinging folks about the build servers now to confirm)

Ack, I'm seeing another potential issue w/the current packaging breakdown, in
that as it stands right now, 32-bit and 64-bit libhugetlbfs packages would
conflict with one another, as both contain hugetlbd. I know they're actually the
same file, but we'll need to work around that somehow -- possibly yet another
sub-package...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.