[Bug 191014] Review Request: ganymed

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ganymed


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191014





------- Additional Comments From green at redhat.com  2006-05-08 00:17 EST -------
Hi Robert - this is cool, thanks.

I'm no expert, but here are some comments based on the feedback I've received
from my review experiences...

* Why have all those macro definitions, conditional and otherwise, at the top
instead of just...
%define gcj_support     1
?

* I've been using %{?dist} in Release tags, like
Release:    1%{?dist}

* There's a preference to not use macros in Source0.  It's something somebody
should be able to wget directly.

* Missing '.' at the end of %description.

* Single line %post[un] bits should look like this...
%post -p %{_bindir}/rebuild-gcj-db
%postun -p %{_bindir}/rebuild-gcj-db
(rpmlint will complain about this)

Thanks!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.