[Bug 191218] Review Request: PyScript - Postscript graphics with Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: PyScript - Postscript graphics with Python


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191218





------- Additional Comments From paultcochrane at gmail.com  2006-05-12 05:27 EST -------
(In reply to comment #1)
Thanks for the review!

> - BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
> - n)
Corrected.

> - Specfile should be in the format %{name}.spec
Corrected.

> - Package is marked as relocatable, is that really needed? It probably isn't so
> that has to be fixed (get rid of Prefix). If it really is necessary you need to
> explain why.
Removed Prefix: attribute from spec file and replaced %{prefix} with the actual
path.  This, however, makes rpmlint give a lot of errors saying that the path is
hardcoded.  Is this correct?

> - some paths are not replaced with RPM macros
Sorry, I'm not 100% sure which ones are incorrect.

> - The BuildRoot must be cleaned at the beginning of %install (add rm -rf
> $RPM_BUILD_ROOT)
Corrected.

The new SPEC and SRPM file URLs are:
Spec URL: http://dl.sourceforge.net/sourceforge/pyscript/pyscript.spec
SRPM URL: http://dl.sourceforge.net/sourceforge/pyscript/pyscript-0.6-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.