[Bug 191239] Review Request: qjackctl - Qt based JACK control application

bugzilla at redhat.com bugzilla at redhat.com
Fri May 12 17:28:52 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qjackctl - Qt based JACK control application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239





------- Additional Comments From paul at city-fan.org  2006-05-12 13:28 EST -------
(In reply to comment #2)
> > just use rm istead of %__rm macro
> 
> Fixed. Is this a general policy (ie: don't even think of using macros for
> commands) or personal preference?

It's personal preference. I personally consider this change to be a regression
since "%__rm" expends to a fully-qualified pathname, unlike plain "rm". Hence
the rpm build may now behave differently depending on the setting of the
builder's PATH variable (they might have a wrapper script for rm earlier in
their PATH for example, which always asked for confirmation of any deletes),
which is not a good thing.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list