[Bug 191239] Review Request: qjackctl - Qt based JACK control application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: qjackctl - Qt based JACK control application


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191239





------- Additional Comments From green at redhat.com  2006-05-12 13:38 EST -------
(In reply to comment #3)
> It's personal preference. I personally consider this change to be a regression
> since "%__rm" expends to a fully-qualified pathname, unlike plain "rm". 

What about %{__make}?  I've been asked to change that to "make" in some reviews.

Fernando - I think people also like to see:
Source0: http://dl.sourceforge.net/qjackctl/qjackctl-0.2.20.tar.gz
instead of 
Source0: http://dl.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
since it is directly wget'able, although I don't know if it's 
official policy or not.

AG


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.