[Bug 192049] Review Request: gnash - GNU Flash player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnash - GNU Flash player


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192049





------- Additional Comments From petersen at redhat.com  2006-05-17 09:46 EST -------
Thanks for the speedy review. :)

Sorry I missed the upstream update again....

(In reply to comment #1)
> * klash is now gnash-klash for the subpackages upstream, this name should
>   be used here also for consistency with what will appear.

Ok.

> * there is a security issue that should be patched in fedora extras package, 
>   indeed there is an insecure use of /tmp. If it is too much work, at least
>   there should be a note somewhere.

Is there a patch from cvs that can be backported for this?

> * the documentation should be distributed (see the specfile in the tarball
>   for hints on how to do this), except if there is a good reason not to 
>   distribute it? At least manpage and html manual, info files and 
>   scrollkeeper files would be bonus 

Sounds good.  I added buildrequires docbook2X for that.

(In reply to comment #2)
> W: gnash devel-file-in-non-devel-package /usr/lib/libgnashasobjs.so
> W: gnash devel-file-in-non-devel-package /usr/lib/libgnashbackend.so
> W: gnash devel-file-in-non-devel-package /usr/lib/libgnashgeo.so
> W: gnash devel-file-in-non-devel-package /usr/lib/libgnashserver.so
> W: gnash devel-file-in-non-devel-package /usr/lib/libgnashbase.so

I removed them for now.

> There is also this warning that may be problematic, although I don't
> know how to solve it:
> E: klash binary-or-shlib-defines-rpath /usr/lib/kde3/libklashpart.so
> ['/usr/lib', '/usr/lib/qt-3.3/lib']

I added --disable-rpath to configure.

> * Maybe the gnash package should be in 
> Group:          Applications/Multimedia
> and not in Applications/Internet (the plugins are rightly in
Applications/Internet).

Thanks, fixed.

I also subpackaged the libraries.

http://people.redhat.com/petersen/extras/gnash.spec
SRPM URL: http://people.redhat.com/petersen/extras/gnash-0.7.1-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.