[Bug 188574] Review Request: rss-glx -- Really Slick Screensavers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rss-glx -- Really Slick Screensavers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188574


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list at redhat.com             |review at redhat.com

tibbs at math.uh.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




------- Additional Comments From tibbs at math.uh.edu  2006-05-20 01:26 EST -------
I figured this could use a little attention, so here are some comments:

Could you provide a script to generate your patched source tarball from upstream's?

Might it be possible to include the matrixview hack but replace the images with,
I don't know, the Fedora logo and pictures of Seth or something?  Or even
nothing; it only uses the compiled-in images if the user doesn't specify a
directory containing images.

The package builds in mock (development, x86_64) but rpmlint finds quite a bit
to complain about.  I'll group the complaints by type:

W: rss-glx no-version-in-last-changelog
W: rss-glx-debuginfo no-version-in-last-changelog
W: rss-glx-gnome-screensaver no-version-in-last-changelog
W: rss-glx-kde no-version-in-last-changelog
W: rss-glx-xscreensaver no-version-in-last-changelog

Many of your changelog entries don't include version information.

E: rss-glx obsolete-not-provided rss_glx

If you obsolete something, you must also provide it.

E: rss-glx zero-length /usr/share/doc/rss-glx-0.8.1/NEWS
E: rss-glx zero-length /usr/share/doc/rss-glx-0.8.1/AUTHORS

No point in packaging these.

W: rss-glx-debuginfo dangling-relative-symlink
/usr/src/debug/rss-glx_0.8.1.p/oglc_src/driver.cpp ../src/driver.cpp
W: rss-glx-debuginfo dangling-relative-symlink
/usr/src/debug/rss-glx_0.8.1.p/other_src/driver.c ../src/driver.cpp
W: rss-glx-debuginfo dangling-relative-symlink
/usr/src/debug/rss-glx_0.8.1.p/reallyslick/cpp_src/driver.cpp ../../src/driver.cpp
W: rss-glx-debuginfo dangling-relative-symlink
/usr/src/debug/rss-glx_0.8.1.p/reallyslick/c_src/driver.c ../../src/driver.cpp

These all seem to be bogus.

W: rss-glx-gnome-screensaver no-documentation
W: rss-glx-kde no-documentation
W: rss-glx-xscreensaver no-documentation

Definitely bogus.

A large number of warnings like this:
W: rss-glx-gnome-screensaver dangling-symlink
/usr/libexec/gnome-screensaver/rss-glx-cyclone /usr/bin/cyclone

rpmlint is smart enough to ignore symlinks to files in required packages when
those symlinks are in -devel packages, but not in this case.  These can all be
ignored.

W: rss-glx-gnome-screensaver non-standard-dir-in-usr libexec

I was recently informed on IRC that /usr/libexec is not discouraged in Fedora,
so I don't understand this warning at all.

I'll do a full review tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.