[Bug 188574] Review Request: rss-glx -- Really Slick Screensavers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: rss-glx -- Really Slick Screensavers


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188574





------- Additional Comments From nphilipp at redhat.com  2006-05-22 05:26 EST -------
(In reply to comment #2)
> I figured this could use a little attention, so here are some comments:
> 
> Could you provide a script to generate your patched source tarball from
upstream's?

I've included the script, necessary patch file and a README.fedora to describe
these as documentation. I've uploaded these also here:

http://tiptoe.de/dav/README.fedora
http://tiptoe.de/dav/rss-glx-rm-matrixview.sh
http://tiptoe.de/dav/rss-glx-0.8.1-0.8.1.p.diff

The new, script-generated tarball is also at:

http://tiptoe.de/dav/rss-glx_0.8.1.p.tar.bz2

> 
> Might it be possible to include the matrixview hack but replace the images with,
> I don't know, the Fedora logo and pictures of Seth or something?  Or even
> nothing; it only uses the compiled-in images if the user doesn't specify a
> directory containing images.

The format in which these default images are kept is quite obscure... I might
try it at a later point (or hey, I'll accept patches ;-) but for starters we can
do without that hack I think.

> The package builds in mock (development, x86_64) but rpmlint finds quite a bit
> to complain about.  I'll group the complaints by type:
> 
> W: rss-glx no-version-in-last-changelog
> W: rss-glx-debuginfo no-version-in-last-changelog
> W: rss-glx-gnome-screensaver no-version-in-last-changelog
> W: rss-glx-kde no-version-in-last-changelog
> W: rss-glx-xscreensaver no-version-in-last-changelog
> 
> Many of your changelog entries don't include version information.

I'va added version info for the latest and next-to-latest entry, I'm not sure
about the older ones so I'll leave them blank.

> 
> E: rss-glx obsolete-not-provided rss_glx
> 
> If you obsolete something, you must also provide it.

I don't obsolete it anymore as it was only for an old version I never really
distributed.

> E: rss-glx zero-length /usr/share/doc/rss-glx-0.8.1/NEWS
> E: rss-glx zero-length /usr/share/doc/rss-glx-0.8.1/AUTHORS
> 
> No point in packaging these.

Removed.

> 
> W: rss-glx-debuginfo dangling-relative-symlink
> /usr/src/debug/rss-glx_0.8.1.p/oglc_src/driver.cpp ../src/driver.cpp
> W: rss-glx-debuginfo dangling-relative-symlink
> /usr/src/debug/rss-glx_0.8.1.p/other_src/driver.c ../src/driver.cpp
> W: rss-glx-debuginfo dangling-relative-symlink
> /usr/src/debug/rss-glx_0.8.1.p/reallyslick/cpp_src/driver.cpp ../../src/driver.cpp
> W: rss-glx-debuginfo dangling-relative-symlink
> /usr/src/debug/rss-glx_0.8.1.p/reallyslick/c_src/driver.c ../../src/driver.cpp
> 
> These all seem to be bogus.
> 
> W: rss-glx-gnome-screensaver no-documentation
> W: rss-glx-kde no-documentation
> W: rss-glx-xscreensaver no-documentation
> 
> Definitely bogus.
> 
> A large number of warnings like this:
> W: rss-glx-gnome-screensaver dangling-symlink
> /usr/libexec/gnome-screensaver/rss-glx-cyclone /usr/bin/cyclone
> 
> rpmlint is smart enough to ignore symlinks to files in required packages when
> those symlinks are in -devel packages, but not in this case.  These can all be
> ignored.
> 
> W: rss-glx-gnome-screensaver non-standard-dir-in-usr libexec
> 
> I was recently informed on IRC that /usr/libexec is not discouraged in Fedora,
> so I don't understand this warning at all.
> 
> I'll do a full review tomorrow.

Thanks.

I've uploaded the new spec file as well, new SRPM is uploading at the moment,
both will be at:

http://tiptoe.de/dav/rss-glx.spec
http://tiptoe.de/dav/rss-glx-0.8.1-0.3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.