[Bug 212715] Review Request: openvrml - VRML/X3D runtime library

bugzilla at redhat.com bugzilla at redhat.com
Tue Nov 14 07:59:03 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openvrml - VRML/X3D runtime library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715





------- Additional Comments From rc040203 at freenet.de  2006-11-14 02:58 EST -------
(In reply to comment #15)
> (In reply to comment #11)

> > > > 4. use %setup -q instead of %setup
> > Optional.
> 
> What's it do?

-q silences the untarring of source tarball (tar xf instead of tar xvf). As
verbose untarring increases the size of log files, some people prefer 
"%setup -q". 

However given the size of the log files building openvrml produces, this
probably is negligible ;)
 
> > > > 5. use %configure --disable-dependency-tracking to speed up build process
> > 
> > Optional, left to the packager's preference. This doesn't make much sense for
> > this package, because this speed up is marginal for this package.
> 
> True; I won't bother with it, at least for now.
OK with me.
 
> > > > 7. avoid unnecessary docs duplication in every subpackage
> > > 
> > > Users shouldn't need to be aware of the package dependency chain in order to 
> > > find the README or license for the package. Would it be acceptable to install 
> > > symlinks?
> > No.
> 
> Okay. I'll leave it as-is.
Feel free to do as you like. Rule of thumb should be "docs should accompany
those components they document" and "ship them when you feel it's necessary".

You're the upstream author, so feel free to add "ChangeLogs", READMEs, License
files where you feel them to be appropriate.

> spec: http://endoframe.com/openvrml.spec
> srpm: http://endoframe.com/openvrml-0.16.1-3.src.rpm
> 
> I hope I haven't missed anything.

Will try to look into this later today.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list