[Bug 212715] Review Request: openvrml - VRML/X3D runtime library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: openvrml - VRML/X3D runtime library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212715





------- Additional Comments From rc040203 at freenet.de  2006-11-14 08:35 EST -------
(In reply to comment #16)
> > I hope I haven't missed anything.

Unfortunately, you did :(
 
> Will try to look into this later today.

Some MUSTFIXES remain:

* Some %post/%pre sections still lack a blank line at their end.

* The infos do not install/uninstall correctly:
- "info openvrml-gtkplug" doesn't jump to the corresponding info pages
- "rpm -e openvrml-gtkplug" fails:
install-info: warning: no entries found for
`/usr/share/info/openvrml-gtkplug.info.gz'; nothing deleted

The origin is a missing direntry inside of the *.info (cf. the openvrml-gtkplug
entry in /usr/share/info/dir after installing the rpm).
Normally this indicates broken/incomplete texinfo sources. 

Standard work-around would be to either patch/fix the sources, or to pass the
necessary info to install-info inside of the specs.

RECOMMENDATION:

* I recommend using %{?dist} in %release. In your case this would be
Release: 3%{?dist}

This eases a package's maintenance in longer terms.

There exist other minor issue, which IMO don't have to be addressed now and are
better be addressed after importing the packaging in FE.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.