[Bug 216519] Review Request: sdparm - List or change SCSI disk parameters

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 20 22:30:35 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sdparm -  List or change SCSI disk parameters


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216519


peter at thecodergeek.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |peter at thecodergeek.com




------- Additional Comments From peter at thecodergeek.com  2006-11-20 17:30 EST -------
As I recall, this is also useful for SATA devices. If it's alright with you, I
think adding that to the %description and Summary ("List or change SCSI/SATA
disk parameters") would be beneficial for those wanting to find this through a
search or similar.

Also, your %build section appears to be missing a make call:
> make %{?_smp_mflags}

Lastly, why is there a need for the checking of %buildroot in %clean/%install? 

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list