[Bug 216519] Review Request: sdparm - List or change SCSI disk parameters

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: sdparm -  List or change SCSI disk parameters


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=216519





------- Additional Comments From terjeros at phys.ntnu.no  2006-11-20 17:57 EST -------
(In reply to comment #1)
> As I recall, this is also useful for SATA devices. If it's alright with you, I
> think adding that to the %description and Summary ("List or change SCSI/SATA
> disk parameters") would be beneficial for those wanting to find this through a
> search or similar.

Fixed,  better now?

> Also, your %build section appears to be missing a make call:
> > make %{?_smp_mflags}

Indeed!
 
> Lastly, why is there a need for the checking of %buildroot in %clean/%install? 

A upstream thingie, removed.

New files:
SPEC: http://www.pvv.ntnu.no/~terjeros/rpms/sdparm/sdparm.spec
SRPMS: http://www.pvv.ntnu.no/~terjeros/rpms/sdparm/sdparm-1.00-3.fc6.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.