[Bug 193059] Review Request: ibmasm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ibmasm


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193059





------- Additional Comments From paul at all-the-johnsons.co.uk  2006-09-10 11:12 EST -------
There should only be one release tag and (from what I've been told from other RH
engineers) the dist tag is optional. I would want a dist tag. The tarball should
be %{name}-%{version}.tar.bz2 (or similar). The %{release} should really be a
number rather than a macro. Yes, it's a pain, but it solves both problems.

%package devel
Requires: %{name} = %{version}

You need this to be %{version}-%{release} to keep things in line

%install
make _LIB=%{_libdir} ROOT=${RPM_BUILD_ROOT} install

Will the package not let you use make DEST_DIR=%{buildroot} install?

install ../ibmasm.init ${RPM_BUILD_ROOT}%{_sysconfdir}/rc.d/init.d/ibmasm

Please use -m for the permission (I have a feeling it's a blocker if you don't
use it). You have in the %files devel

%attr(644,root,root) %{_includedir}/ibmasm/*.h

If you use install -m 0644 in the %install step, the %attr is not required.

%{_sbindir}/ibmsphalt
%{_sbindir}/ibmspup

Can be globbed - %{_sbindir}/ibms*

The package is happy in mock (from your srpm)

Correct these and I'll do the full review - I can't see many more problems though.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.