[Bug 208250] Review Request: piklab - Development environment for applications based on PIC and dsPIC microcontrollers
bugzilla at redhat.com
bugzilla at redhat.com
Thu Sep 28 19:11:40 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: piklab - Development environment for applications based on PIC and dsPIC microcontrollers
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=208250
------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp 2006-09-28 15:11 EST -------
(In reply to comment #7)
> (In reply to comment #6)
> > Bad:
> >
> > - Don't sourced QT environment variables.
> > (this should make sure, that the build runs agains the right Qt version)
>
> This isn't needed.
I also think this is not needed because the files under /etc/profile.d
is "source"d even without explicitly sourced. Actually many packages
using Qt don't source Qt environ explicitly, this can be seen under:
http://buildsys.fedoraproject.org/logs/fedora-development-extras/
> > - Rpmlint complaints on binary rpm:
> > E: piklab summary-too-long Development environment for applications based on
> PIC
> > and dsPIC microcontrollers
>
> I don't have this error!
> Mamoru, please, could you confirm?
I HAVE. "rpmlint -I summary-too-long" says summary must be less than
80 characters (not longer than 79), however, this summary seems to
have just 80 characters......
>
> > W: piklab dangling-relative-symlink /usr/share/doc/HTML/en/piklab/common
> > ../doc/common
This warning is not a problem because kdelibs is installed together
and it corrects this.
> > /tmp/piklab-0.11.3-2.i686.rpm.5998/usr/share/applications/kde/piklab.desktop:
> > warning: file contains key "DocPath", this key is currently reserved for use
> > within KDE, and should in the future KDE releases be prefixed by "X-"
>
> Why do you want I make a better package than you?
I think this can be ignored.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the Fedora-package-review
mailing list