[Bug 233850] Review Request: freepops - POP3 interface to webmails

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freepops - POP3 interface to webmails


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233850





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2007-04-09 11:48 EST -------
Umm... 4 months has passed since I was reviewing
bug 208113 and I have completely forgotton my previous
review....

Well, this is a first review of this bug. While perhaps
I have not checked this package fully, I think some cleanup
is needed before I can do so.

For 0.2.0-4:

Z. First..
* Unneeded comment
  - Please remove all unneeded comments.... These comments
    make it harder to read spec file easily.

A. Description section
* Source0
  - Please specify the URL where we can get tarball at Source0

* Redundant BuildRequires
  - The following BRs are not needed because they are included
    in the minimal buildroot environment.
-------------------------------------------------
sed
-------------------------------------------------

* Pre/post stage requires for service installation
  - Service installation requires some %Requires(post) and so on.
    Please check the "Services" section of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

B. Build stage
* Parallel make
  - Please enable parallel make support when it is possible.
    When it is not possible, write a note as a comment.

* Fedora specific compilation flags
  - are not passed.
---------------------------------------------------
building luay
echo " building dep for luay.c"
 building dep for luay.c
gcc -I. -I/builddir/build/BUILD/freepops-0.2.0/modules/include -O2 -g3 -Wall
-DHAVE_CONFIG_H -I/builddir/build/BUILD/freepops-0.2.0     -I.
-I/builddir/build/BUILD/freepops-0.2.0/modules/include  -MM luay.c > .luay.d;
----------------------------------------------------
    - where fedora specific compilation flags (can be checked by
      "rpm --eval %optflags" are
----------------------------------------------------
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic
-fasynchronous-unwind-tables
----------------------------------------------------
      and this must be used.

C. Install stage
* Timestamps
  - Keep timestamps on the files which are not created or modified
    during build stage.
----------------------------------------------------
install -m755 %{SOURCE1} ${RPM_BUILD_ROOT}%{_initrddir}/freepopsd
install -m644 %{SOURCE2} ${RPM_BUILD_ROOT}%{_sysconfdir}/sysconfig/freepopsd
----------------------------------------------------
    Please use "install -p".

D. File entry
* Directory ownership
  - The following directories are not owned by any packages.
----------------------------------------------------
%{_datadir}/freepops/
%{_sysconfdir}/sysconfig/
%{_libdir}/freepops/
---------------------------------------------------- 
    Note: the entry 
---------------------------------------------------
%files
%defattr(-,root,root,-)
foo/
---------------------------------------------------
    (where foo is a directory) means the directory foo/ itself and
    all the files/directories/etc under foo/, while
---------------------------------------------------
%files
%defattr(-,root,root,-)
%dir foo/
---------------------------------------------------
    means the directory foo/ only.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.