[Bug 233850] Review Request: freepops - POP3 interface to webmails

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freepops - POP3 interface to webmails


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233850





------- Additional Comments From francesco at francesco-laurita.info  2007-04-10 05:49 EST -------
(In reply to comment #6)

> Z. First..
> * Unneeded comment
>   - Please remove all unneeded comments.... These comments

done!

> A. Description section
> * Source0
>   - Please specify the URL where we can get tarball at Source0
done


> * Redundant BuildRequires

done

> * Pre/post stage requires for service installation
>   - Service installation requires some %Requires(post) and so on.

Done by adding
Requires(post): /sbin/chkconfig
Requires(preun): /sbin/chkconfig
Requires(preun): /sbin/service


> B. Build stage
> * Parallel make

By adding %{?_smp_mflags} after 
make it not works. 
I'm not sure if parallel make isn't supported or it's just a my mistake

> * Fedora specific compilation flags
>   - are not passed.

fixed

> C. Install stage
> * Timestamps
>   - Keep timestamps on the files which are not created or modified

done

> D. File entry
> * Directory ownership

fixed


Spec URL: http://francesco-laurita.info/files/fedora/freepops.spec
SRPM URL: http://francesco-laurita.info/files/fedora/freepops-0.2.2-1.src.rpm

Cya!!!


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.