[Bug 222338] Review Request: initng-conf-gtk - InitNG configuration and control utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: initng-conf-gtk - InitNG configuration and control utility


https://bugzilla.redhat.com/show_bug.cgi?id=222338





------- Additional Comments From akahl at iconmobile.com  2007-12-12 18:23 EST -------
Sorry for taking so long, Daniel.

You haven't posted a link to a new srpm file but I assume the old location is
still valid, hence I'm using
http://download.initng.org/initng-gui/initng-conf-gtk/initng-conf-gtk-0.5.1-1.fc8.src.rpm
for the continued review.

Following issues remain or are new:
* rpmlint (on srpm):
 - initng-conf-gtk.src: W: strange-permission initng-conf-gtk.spec 0755
Please remove the executable bit from the spec file.

* The sources used to build the package matches the upstream source
28b43e0dc8e5525a9c12c7f597f6e5829223f57d  initng-conf-gtk-0.5.1.tar.gz
E Consistent use of macros:
Please use %{__rm} for rm and %{__ln_s} for 'ln -s', %{__mkdir} for mkdir,
%{__make} for make, ${_bindir} for /usr/bin
E Timestamps:
To preserve timestamps on files upon copying, always add the -p option to both
cp and install, additionally change the 'make install' to
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"
* No header files
* No static libs
* No library files
E Scriptlets are NOT sane (yet):
- gtk-update-icon-cache must be executed with '|| :' at the end (instead of ';')
so %post doesn't fail completely if something goes wrong

- update-desktop-database is missing in %post

E Desktop file handled properly (vendor id):
If a package specifies no vendor, use "fedora" as vendor id, see
http://fedoraproject.org/wiki/Packaging/Guidelines#head-d559ee7363418a5840ce63090c608c991cd39ce6
Thus what Yuichi wrote in Comment #2 is wrong.

E Whitespace in spec file:
Although rpmlint doesn't complain about this, you're mixing up spaces and tabs
in your spec file scripts. Please use one of them consistently.

* Package does not own files or directories already owned by other packages
E Packages owns all directories that it creates:
file /usr/share/initng-conf-gtk is not owned by any package
Please replace
{_datadir}/%{name}/%{name}.glade
with
{_datadir}/%{name}


Aside from the issues left, the new source package in fact produces a working
program. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.